test: quota and refquota params #608

Abhinandan-Purkait · 2025-01-07T09:27:11Z

Adds test for feat(zfs-localpv): add option for choosing between refquota and quota #542
Adds a fix. Bug introduced in the PR fix(reservation): while expanding, with refquota setting #595 . Causing failure in resize when thinprovision is no

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

shellcheck

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

zfs-localpv/ci/ci-test.sh

Line 108 in e02cfa7

kubectl get zfssnapshots.zfs.openebs.io -n $OPENEBS_NAMESPACE -oyaml

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

zfs-localpv/ci/ci-test.sh

Line 117 in e02cfa7

    
           for node in $(kubectl get nodes -n $OPENEBS_NAMESPACE -o jsonpath='{.items[*].metadata.name}'); do

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Declare and assign separately to avoid masking return values. SC2155

zfs-localpv/ci/ci-test.sh

Line 118 in e02cfa7

    
           local zfsNode=$(kubectl get zfsnode -n $OPENEBS_NAMESPACE -o jsonpath="{.items[?(@.metadata.ownerReferences[0].name=='${node}')].metadata.name}")

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

zfs-localpv/ci/ci-test.sh

Line 118 in e02cfa7

    
           local zfsNode=$(kubectl get zfsnode -n $OPENEBS_NAMESPACE -o jsonpath="{.items[?(@.metadata.ownerReferences[0].name=='${node}')].metadata.name}")

⚠️ [shellcheck] _{reported by reviewdog 🐶}
Declare and assign separately to avoid masking return values. SC2155

zfs-localpv/ci/ci-test.sh

Line 122 in e02cfa7

    
           local nodeDriver=$(kubectl get pods -l name=openebs-zfs-node -o jsonpath="{.items[?(@.spec.nodeName=='${node}')].metadata.name}" -n $OPENEBS_NAMESPACE)

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

zfs-localpv/ci/ci-test.sh

Line 122 in e02cfa7

    
           local nodeDriver=$(kubectl get pods -l name=openebs-zfs-node -o jsonpath="{.items[?(@.spec.nodeName=='${node}')].metadata.name}" -n $OPENEBS_NAMESPACE)

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

zfs-localpv/ci/ci-test.sh

Line 124 in e02cfa7

kubectl delete pod "${nodeDriver}" -n $OPENEBS_NAMESPACE

📝 [shellcheck] _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting. SC2086

zfs-localpv/ci/ci-test.sh

Line 127 in e02cfa7

kubectl delete zfsnode "${zfsNode}" -n $OPENEBS_NAMESPACE

Signed-off-by: Abhinandan Purkait <[email protected]>

Abhinandan-Purkait force-pushed the test_quota branch from b399c87 to e02cfa7 Compare January 7, 2025 09:27

github-actions bot reviewed Jan 7, 2025

View reviewed changes

Abhinandan-Purkait force-pushed the test_quota branch from e02cfa7 to c59cf04 Compare January 7, 2025 09:29

Abhinandan-Purkait marked this pull request as ready for review January 7, 2025 15:25

Abhinandan-Purkait requested a review from tiagolobocastro January 7, 2025 15:26

Abhinandan-Purkait force-pushed the test_quota branch from 58e8c8d to 81c04b1 Compare January 8, 2025 06:33

Abhinandan-Purkait requested a review from sinhaashish January 8, 2025 06:34

fix: remove invalid character from the set command

102ed7d

Signed-off-by: Abhinandan Purkait <[email protected]>

Abhinandan-Purkait force-pushed the test_quota branch from 81c04b1 to 62913e0 Compare January 9, 2025 05:37

test: quota and refquota params

0479268

Signed-off-by: Abhinandan Purkait <[email protected]>

Abhinandan-Purkait force-pushed the test_quota branch from 62913e0 to 0479268 Compare January 9, 2025 05:39

Abhinandan-Purkait requested review from niladrih and dsharma-dc January 9, 2025 13:55

tiagolobocastro approved these changes Jan 9, 2025

View reviewed changes

dsharma-dc approved these changes Jan 9, 2025

View reviewed changes

Abhinandan-Purkait merged commit 20acc0d into develop Jan 10, 2025
6 checks passed

sinhaashish deleted the test_quota branch January 10, 2025 09:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: quota and refquota params #608

test: quota and refquota params #608

Abhinandan-Purkait commented Jan 7, 2025 •

edited

Loading

github-actions bot left a comment

test: quota and refquota params #608

test: quota and refquota params #608

Conversation

Abhinandan-Purkait commented Jan 7, 2025 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

Abhinandan-Purkait commented Jan 7, 2025 •

edited

Loading